Add decision record for the removal of the init() method
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romaricpascal
force-pushed
the
remove-init-method
branch
from
8889f91 to
ed1b716
Compare
|
|
||
| Component initialisation will be reduced to `new ComponentClass()` instead of `new ComponentClass().init()`, so users will need to update their code to reflect this. | ||
|
|
||
| This will only affect users that were taking responsibility for instantiating components on specific elements themselves. Users who rely on `initAll()` will not have any changes to make as we'll have updated that function's implementation. |
There was a problem hiding this comment.
Sorry, felt like the words were hiding the meaning:
Suggested change
| This will only affect users that were taking responsibility for instantiating components on specific elements themselves. Users who rely on `initAll()` will not have any changes to make as we'll have updated that function's implementation. | |
| The `initAll()` method will not be affected. |
There was a problem hiding this comment.
Mind if I mix both approaches, to clarify which users will need to update?
Suggested change
| This will only affect users that were taking responsibility for instantiating components on specific elements themselves. Users who rely on `initAll()` will not have any changes to make as we'll have updated that function's implementation. | |
| The `initAll()` method will not be affected. Only users that were instantiating components on specific elements themselves will need to update their code. |
There was a problem hiding this comment.
If we've already got it above, leave it?
There was a problem hiding this comment.
Doesn't hurt to have it there as well if someone gets linked directly to this section (they might not scroll back up).
There was a problem hiding this comment.
@colinrotherham Updated that bit, which I'd missed 😊
There was a problem hiding this comment.
Sounds good in isolation, but repeats text from the paragraph above.
How about my new suggestion in #33 (comment) and #33 (review)?
romaricpascal
force-pushed
the
remove-init-method
branch
from
f5f3a4b to
ed4fbf0
Compare
36degrees
force-pushed
the
throw-errors-js-constructors
branch
from
4608371 to
ab64f7a
Compare
romaricpascal
force-pushed
the
remove-init-method
branch
from
ed4fbf0 to
637a08c
Compare
36degrees
force-pushed
the
throw-errors-js-constructors
branch
from
ab64f7a to
10a04d4
Compare
romaricpascal
force-pushed
the
remove-init-method
branch
from
637a08c to
37f1e1d
Compare
romaricpascal
force-pushed
the
remove-init-method
branch
from
37f1e1d to
5c405f0
Compare
colinrotherham
approved these changes
Jul 28, 2023
Co-authored-by: Colin Rotherham <work@colinr.com>
romaricpascal
force-pushed
the
remove-init-method
branch
from
5917ceb to
7786c65
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.